This repository was archived by the owner on Oct 22, 2019. It is now read-only.
Support custom user model with USERNAME_FIELD != "username"#534
Open
dpretty wants to merge 3 commits intobread-and-pepper:masterfrom
Open
Support custom user model with USERNAME_FIELD != "username"#534dpretty wants to merge 3 commits intobread-and-pepper:masterfrom
dpretty wants to merge 3 commits intobread-and-pepper:masterfrom
Conversation
Contributor
|
Thanks! This change looks very good but we won't be able to merge it until we resolve #535 |
Contributor
|
#535 that was blocking this PR from merging is finally resolved. Could you rebase your PR on current master so we can have it tested in Travis again? When doing rebase you can also squash your changes in order to keep commit log more concise. |
|
Should this change cover the scenario where the Custom User model does not even have a field called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using a custom auth model with USERNAME_FIELD = "email".
The changes here are enough, along with
to get django-userena up and running with my project. However, I haven't done any thorough testing yet.